frost/bdk
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove deprecated get_checksum{,_bytes} routines

Browse Source 
There are deprecated since 0.24.0, i.e. they can be removed now.
This commit is contained in:
Sebastian Falbesoner 2024-01-02 03:55:43 +01:00
parent 7eff024213
commit 179cfeff51
No known key found for this signature in database
GPG Key ID: C2371D91CB716EA7
1 changed files with 0 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
crates/bdk/src/descriptor/checksum.rs
View File

@ -107,29 +107,8 @@ pub fn calc_checksum(desc: &str) -> Result<String, DescriptorError> {
.map(|b| unsafe { String::from_utf8_unchecked(b.to_vec()) }) .map(|b| unsafe { String::from_utf8_unchecked(b.to_vec()) })
} }
// TODO in release 0.25.0, remove get_checksum_bytes and get_checksum
// TODO in release 0.25.0, consolidate calc_checksum_bytes_internal into calc_checksum_bytes // TODO in release 0.25.0, consolidate calc_checksum_bytes_internal into calc_checksum_bytes
/// Compute the checksum bytes of a descriptor
#[deprecated(
since = "0.24.0",
note = "Use new `calc_checksum_bytes` function which excludes any existing checksum in the descriptor string before calculating the checksum hash bytes. See https://github.com/bitcoindevkit/bdk/pull/765."
)]
pub fn get_checksum_bytes(desc: &str) -> Result<[u8; 8], DescriptorError> {
calc_checksum_bytes_internal(desc, false)
}
/// Compute the checksum of a descriptor
#[deprecated(
since = "0.24.0",
note = "Use new `calc_checksum` function which excludes any existing checksum in the descriptor string before calculating the checksum hash. See https://github.com/bitcoindevkit/bdk/pull/765."
)]
pub fn get_checksum(desc: &str) -> Result<String, DescriptorError> {
// unsafe is okay here as the checksum only uses bytes in `CHECKSUM_CHARSET`
calc_checksum_bytes_internal(desc, false)
.map(|b| unsafe { String::from_utf8_unchecked(b.to_vec()) })
}
#[cfg(test)] #[cfg(test)]
mod test { mod test {
use super::*; use super::*;