frost/bdk
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(electrum): fixed chain sync issue

Browse Source 
Fixed a logic error in `construct_update_tip` in `electrum_ext.rs` that caused
the local chain tip to always be a block behind the newest confirmed block.
This commit is contained in:
Wei Chen 2023-10-03 18:06:53 +08:00
parent 0a7b60f0f7
commit 1010efd8d6
No known key found for this signature in database
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
crates/electrum/src/electrum_ext.rs
View File

@ -11,8 +11,8 @@ use std::{
str::FromStr, str::FromStr,
}; };
/// We assume that a block of this depth and deeper cannot be reorged. /// We include a chain suffix of a certain length for the purpose of robustness.
const ASSUME_FINAL_DEPTH: u32 = 8; const CHAIN_SUFFIX_LENGTH: u32 = 8;
/// Represents updates fetched from an Electrum server, but excludes full transactions. /// Represents updates fetched from an Electrum server, but excludes full transactions.
/// ///
@ -302,12 +302,12 @@ fn construct_update_tip(
} }
} }
// Atomically fetch the latest `ASSUME_FINAL_DEPTH` count of blocks from Electrum. We use this // Atomically fetch the latest `CHAIN_SUFFIX_LENGTH` count of blocks from Electrum. We use this
// to construct our checkpoint update. // to construct our checkpoint update.
let mut new_blocks = { let mut new_blocks = {
let start_height = new_tip_height.saturating_sub(ASSUME_FINAL_DEPTH); let start_height = new_tip_height.saturating_sub(CHAIN_SUFFIX_LENGTH - 1);
let hashes = client let hashes = client
.block_headers(start_height as _, ASSUME_FINAL_DEPTH as _)? .block_headers(start_height as _, CHAIN_SUFFIX_LENGTH as _)?
.headers .headers
.into_iter() .into_iter()
.map(|h| h.block_hash()); .map(|h| h.block_hash());