3c6075ad96afa238dc3ceca71ba82cb10088bb90 Add Balance struct and conversion from BdkBalance (thunderbiscuit)
4e15badb14d34db4911641f345e99987d132a81c Update BDK to version 0.22 (thunderbiscuit)
Pull request description:
The bindings do not build when attempting this upgrade because `get_balance()` now returns a `Balance` struct (this was merged in bitcoindevkit/bdk#640)
```sh
error[E0308]: mismatched types
--> src/lib.rs:433:9
|
432 | fn get_balance(&self) -> Result<u64, Error> {
| ------------------ expected `Result<u64, bdk::Error>` because of return type
433 | self.get_wallet().get_balance()
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `u64`, found struct `Balance`
|
= note: expected enum `Result<u64, _>`
found enum `Result<Balance, _>`
For more information about this error, try `rustc --explain E0308`.
error: could not compile `bdk-ffi` due to previous error
```
When we upgrade to `0.22.0` we could decide to add the `Balance` struct to the bindings, or simply return the total by calling `get_total()`, which returns a `u64` (same as we have now).
ACKs for top commit:
notmandatory:
ACK 3c6075ad96afa238dc3ceca71ba82cb10088bb90
Tree-SHA512: 13d2f83f992735f4f9619ae339d7834df08385129edf06bac830c298b433571af3f211e92a6da1f4f9646dec27dbd2c6133a035f26eac8757b7a1c94b54b463d
* Add docs for AddressInfo and AddressIndex structs
* Add docs for DatabaseConfig and ElectrumConfig
* Add docs for EsploraConfig struct
* Add docs for TransactionDetails struct
* Add docs for OutPoint struct
* Add docs for TxOut struct
* Add docs for TxBuilder
5944756b780968588e97886d888bb854aa2053ad Added tests for DescriptorSecretKey and DescriptorPublicKey (dhruvbaliyan)
58fea6b2050d9f10b1c5429cce4f4969c155e9e3 Added interfaces DescriptorSecretKey and DescriptorPublicKey (dhruvbaliyan)
4977cb6d68830accf036b192dba3c524253e53f2 Added interface DerivationPath (dhruvbaliyan)
930a1f1eb4a64bf447dec2493edd9948be67f119 Added generate_mnemonic method (dhruvbaliyan)
973013cbdfb0093c9d0bc8d2f5176c981160e060 Removed ExtendedKeyInfo & related methods (dhruvbaliyan)
Pull request description:
Would like to know if anything can be improved. Completes #87
Top commit has no ACKs.
Tree-SHA512: a480535c8965015d860336c717ec3c394778ac08194b0336eeba4209f3e3eff2072873a190dd8c9e4fac1e2f712c7040c838dc1c1a757d53c28866f118c99c17
6d53cbeb2502602d1bab0fd11f63d203f61b507a Fix fmt error (Steve Myers)
1a12f37a2f1c5f99e3b590b3ba070859120a9f8e Set MSRV to 1.57.0 (Steve Myers)
Pull request description:
### Description
The `master` branch is currently not passing the new github checks.
A required dependency of `bdk-ffi-bindgen` is `uniffi_bindgen` and it depends on `os_str_bytes` v6.2.0 which has a MSRV of 1.57.0. I therefore had to make the MSRV of `bdk-ffi` also 1.57.0 and update the github actions. This PR also fixes a small `cargo fmt` warning.
### Notes to the reviewers
```shell
% cargo +1.56.1 build
error: package `os_str_bytes v6.2.0` cannot be built because it requires rustc 1.57.0 or newer, while the currently active rustc version is 1.56.1
```
```shell
% cargo tree -i os_str_bytes
os_str_bytes v6.2.0
└── clap_lex v0.2.4
└── clap v3.1.18
└── uniffi_bindgen v0.19.3
└── bdk-ffi-bindgen v0.2.0 (/Users/steve/git/notmandatory/bdk-ffi/bdk-ffi-bindgen)
```
### Checklists
#### All Submissions:
* [x] I've signed all my commits
* [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
* [x] I ran `cargo fmt` and `cargo clippy` before committing
Top commit has no ACKs.
Tree-SHA512: 87ad4a02d91184b421871354b1f5c31d906bf7460fe992db15666da32a65f13d8fbaf4ae53928f410a7206b195c8dff76af07210c144a4d02854ceb6af265f7e
