frost/bdk-ffi
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge bitcoindevkit/bdk-ffi#145: Fix fee parameter typo in TransactionDetails

Browse Source 
c722223b49ea05b9d89c70b87531a2029d905849 Fix fee parameter typo in TransactionDetails (dhruvbaliyan)

Pull request description:

  Solves issue #136
  Generated Kotlin file now have "fee" in TransactionDetails as parameter instead of "fees"
  ```
  data class TransactionDetails (
      var fee: ULong?,
      var received: ULong,
      var sent: ULong,
      var txid: String
  ) {
      // ...
  }
  ```

ACKs for top commit:
  thunderbiscuit:
    Tested ACK c722223. Works as expected in my apps. Thanks for the quick fix!

Tree-SHA512: c55a6e77ca5a0cd19758fc628fc48ed997b3c86247a1eadf5be77771818e3aa5f4db10025e7aa30d05be573e94d7439b15c7fc1f3d6dad752487f7f1ad455367
This commit is contained in:
Steve Myers 2022-04-25 21:30:09 -07:00
commit e6a6be5b60
No known key found for this signature in database
GPG Key ID: 8105A46B22C2D051
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/bdk.udl
View File

@ -73,7 +73,7 @@ interface DatabaseConfig {
};
dictionary TransactionDetails {
u64? fees;
u64? fee;
u64 received;
u64 sent;
string txid;

4
src/lib.rs
View File

@ -51,7 +51,7 @@ pub enum BlockchainConfig {
#[derive(Debug, Clone, PartialEq, Eq, Default)]
pub struct TransactionDetails {
pub fees: Option<u64>,
pub fee: Option<u64>,
pub received: u64,
pub sent: u64,
pub txid: String,
@ -71,7 +71,7 @@ pub enum Transaction {
impl From<&bdk::TransactionDetails> for TransactionDetails {
fn from(x: &bdk::TransactionDetails) -> TransactionDetails {
TransactionDetails {
fees: x.fee,
fee: x.fee,
txid: x.txid.to_string(),
received: x.received,
sent: x.sent,