From e48af63fe6b9d7687986f6da8c4922817f9f84a5 Mon Sep 17 00:00:00 2001 From: thunderbiscuit Date: Fri, 26 Apr 2024 14:40:49 -0400 Subject: [PATCH] refactor: use tuple struct for Mnemonic type --- bdk-ffi/src/keys.rs | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/bdk-ffi/src/keys.rs b/bdk-ffi/src/keys.rs index 40a940e..8f8126b 100644 --- a/bdk-ffi/src/keys.rs +++ b/bdk-ffi/src/keys.rs @@ -18,9 +18,7 @@ use std::ops::Deref; use std::str::FromStr; use std::sync::{Arc, Mutex}; -pub(crate) struct Mnemonic { - inner: BdkMnemonic, -} +pub(crate) struct Mnemonic(pub(crate) BdkMnemonic); impl Mnemonic { pub(crate) fn new(word_count: WordCount) -> Self { @@ -32,23 +30,23 @@ impl Mnemonic { let generated_key: GeneratedKey<_, BareCtx> = BdkMnemonic::generate_with_entropy((word_count, Language::English), entropy).unwrap(); let mnemonic = BdkMnemonic::parse_in(Language::English, generated_key.to_string()).unwrap(); - Mnemonic { inner: mnemonic } + Mnemonic(mnemonic) } pub(crate) fn from_string(mnemonic: String) -> Result { BdkMnemonic::from_str(&mnemonic) - .map(|m| Mnemonic { inner: m }) + .map(Mnemonic) .map_err(Bip39Error::from) } pub(crate) fn from_entropy(entropy: Vec) -> Result { BdkMnemonic::from_entropy(entropy.as_slice()) - .map(|m| Mnemonic { inner: m }) + .map(Mnemonic) .map_err(Bip39Error::from) } pub(crate) fn as_string(&self) -> String { - self.inner.to_string() + self.0.to_string() } } @@ -73,7 +71,7 @@ pub struct DescriptorSecretKey { impl DescriptorSecretKey { pub(crate) fn new(network: Network, mnemonic: &Mnemonic, password: Option) -> Self { - let mnemonic = mnemonic.inner.clone(); + let mnemonic = mnemonic.0.clone(); let xkey: ExtendedKey = (mnemonic, password).into_extended_key().unwrap(); let descriptor_secret_key = BdkDescriptorSecretKey::XPrv(DescriptorXKey { origin: None,