diff --git a/.github/workflows/publish-python.yaml b/.github/workflows/publish-python.yaml index 15ce0b7..a470f72 100644 --- a/.github/workflows/publish-python.yaml +++ b/.github/workflows/publish-python.yaml @@ -43,7 +43,9 @@ jobs: run: bash generate.sh - name: "Build wheel" - run: ${PYBIN}/python setup.py bdist_wheel --verbose + # Specifying the plat-name argument is necessary to build a wheel with the correct name, + # see issue #350 for more information + run: ${PYBIN}/python setup.py bdist_wheel --plat-name manylinux_2_17_x86_64 --verbose - uses: actions/upload-artifact@v2 with: @@ -81,7 +83,9 @@ jobs: - name: "Build wheel" env: ARCHFLAGS: "-arch x86_64 -arch arm64" - run: python3 setup.py bdist_wheel --verbose + # Specifying the plat-name argument is necessary to build a wheel with the correct name, + # see issue #350 for more information + run: python3 setup.py bdist_wheel --plat-name macosx_12_0_universal2 --verbose - uses: actions/upload-artifact@v2 with: diff --git a/.github/workflows/test-python.yaml b/.github/workflows/test-python.yaml index c9f7896..787cf51 100644 --- a/.github/workflows/test-python.yaml +++ b/.github/workflows/test-python.yaml @@ -58,7 +58,9 @@ jobs: run: ${PYBIN}/pip install ./dist/*.whl - name: "Run tests" - run: ${PYBIN}/python -m unittest tests/test_bdk.py --verbose + # Specifying the plat-name argument is necessary to build a wheel with the correct name, + # see issue #350 for more information + run: ${PYBIN}/python -m unittest tests/test_bdk.py --plat-name manylinux_2_17_x86_64 --verbose - name: "Upload artifact test" uses: actions/upload-artifact@v2 diff --git a/bdk-python/setup.py b/bdk-python/setup.py index 70b453e..8823065 100644 --- a/bdk-python/setup.py +++ b/bdk-python/setup.py @@ -51,7 +51,7 @@ print(f"Wallet balance is: {balance.total}") setup( name="bdkpython", - version="0.28.0", + version="0.28.3", description="The Python language bindings for the Bitcoin Development Kit", long_description=LONG_DESCRIPTION, long_description_content_type="text/markdown", @@ -62,4 +62,8 @@ setup( url="https://github.com/bitcoindevkit/bdk-ffi", author="Alekos Filini , Steve Myers ", license="MIT or Apache 2.0", + + # This is required to ensure the library name includes the python version, abi, and platform tags + # See issue #350 for more information + has_ext_modules=lambda: True, )