frost/bdk-ffi
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add include_raw boolean parameter on wallet list_transactions method

Browse Source
This commit is contained in:
thunderbiscuit 2023-03-23 12:32:54 -04:00
parent 2342265c26
commit 3dc6596aa2
No known key found for this signature in database
GPG Key ID: 88253696EB836462
3 changed files with 12 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
api-docs/kotlin/src/main/kotlin/org/bitcoindevkit/bdk.kt
View File

@ -491,7 +491,7 @@ class Wallet(
fun sign(psbt: PartiallySignedTransaction): Boolean {}
/** Return the list of transactions made and received by the wallet. Note that this method only operate on the internal database, which first needs to be [Wallet.sync] manually. */
fun listTransactions(): List<TransactionDetails> {}
fun listTransactions(includeRaw: Boolean): List<TransactionDetails> {}
/** Get the Bitcoin network the wallet is using. */
fun network(): Network {}

2
bdk-ffi/src/bdk.udl
View File

@ -233,7 +233,7 @@ interface Wallet {
boolean sign([ByRef] PartiallySignedTransaction psbt);
[Throws=BdkError]
sequence<TransactionDetails> list_transactions();
sequence<TransactionDetails> list_transactions(boolean include_raw);
Network network();

32
bdk-ffi/src/wallet.rs
View File

@ -120,8 +120,11 @@ impl Wallet {
}
/// Return the list of transactions made and received by the wallet. Note that this method only operate on the internal database, which first needs to be [Wallet.sync] manually.
pub(crate) fn list_transactions(&self) -> Result<Vec<TransactionDetails>, BdkError> {
let transaction_details = self.get_wallet().list_transactions(true)?;
pub(crate) fn list_transactions(
&self,
include_raw: bool,
) -> Result<Vec<TransactionDetails>, BdkError> {
let transaction_details = self.get_wallet().list_transactions(include_raw)?;
Ok(transaction_details
.iter()
.map(TransactionDetails::from)
@ -577,28 +580,19 @@ mod test {
// new index still 0
assert_eq!(
wallet
.get_address(AddressIndex::New)
.unwrap()
.address,
wallet.get_address(AddressIndex::New).unwrap().address,
"bcrt1qqjn9gky9mkrm3c28e5e87t5akd3twg6xezp0tv"
);
// new index now 1
assert_eq!(
wallet
.get_address(AddressIndex::New)
.unwrap()
.address,
wallet.get_address(AddressIndex::New).unwrap().address,
"bcrt1q0xs7dau8af22rspp4klya4f7lhggcnqfun2y3a"
);
// new index now 2
assert_eq!(
wallet
.get_address(AddressIndex::New)
.unwrap()
.address,
wallet.get_address(AddressIndex::New).unwrap().address,
"bcrt1q5g0mq6dkmwzvxscqwgc932jhgcxuqqkjv09tkj"
);
@ -646,18 +640,12 @@ mod test {
.unwrap();
assert_eq!(
wallet
.get_address(AddressIndex::New)
.unwrap()
.address,
wallet.get_address(AddressIndex::New).unwrap().address,
"bcrt1qqjn9gky9mkrm3c28e5e87t5akd3twg6xezp0tv"
);
assert_eq!(
wallet
.get_address(AddressIndex::New)
.unwrap()
.address,
wallet.get_address(AddressIndex::New).unwrap().address,
"bcrt1q0xs7dau8af22rspp4klya4f7lhggcnqfun2y3a"
);