From d9cc3f6ceda46bef3c436770f787960cf6f64fda Mon Sep 17 00:00:00 2001 From: Dev Random Date: Sat, 31 Mar 2018 11:50:06 -0700 Subject: [PATCH] Issue with partial signature entries --- Comments:BIP-0174.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Comments:BIP-0174.md b/Comments:BIP-0174.md index 352da36..85e05b2 100644 --- a/Comments:BIP-0174.md +++ b/Comments:BIP-0174.md @@ -1 +1,5 @@ -Comments for the Partially Signed Transaction Format \ No newline at end of file +# Comments for the Partially Signed Transaction Format + +* Partial signature entries use the map key `{0x02}|{public key}`. However, a single public key may be involved in signing multiple inputs, and the signature will differ in each one. Since the map keys are to be unique, this is a problem. I suggest the following map key instead: `{0x02}|{input index}|{pubkey index}` + +* HD derivation entries waste space by repeating the public key. I recommend using the following map key instead: `{0x03}|{input index}|{pubkey index}`, which also matches previous point.