bitcoin/bips
1
0
Fork 0
mirror of https://github.com/bitcoin/bips.git synced 2025-05-26 12:10:14 +00:00
Code Issues Releases Wiki Activity

Comment on lack of backward compatibility.

Eric Voskuil 2017-02-12 21:10:36 -08:00
parent b308d59567
commit 700291f14e
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Comments:BIP-0151.md

@ -61,4 +61,12 @@ The distinction is however irrelevant, as previously discussed on bitcoin-dev, b
I appreciate that the development of BIP150 and BIP151 was done for the right reasons but that is not at all a justification, especially given that the consequence of node identity will be catastrophic if widely deployed.
--Eric Voskuil, 2017-02-11
The proposal states:
> This proposal is backward compatible. Non-supporting peers will ignore the encinit messages.
This statement is incorrect. Sending content that existing nodes do not expect is clearly an incompatibility. An implementation that ignores invalid content leaves itself wide open to DOS attacks. The handshake must be complete before changes to the protocol can be applied, and only if the negotiation results in a version increment. While it may be desirable for this change to precede the version handshake it cannot be described as backward compatible.
--Eric Voskuil, 2017-02-11