From 46887da16d11892501fa9f5d18dd75359c91f48f Mon Sep 17 00:00:00 2001 From: Paul Imthurn <31865403+pimthurn@users.noreply.github.com> Date: Wed, 15 Aug 2018 13:40:19 -0700 Subject: [PATCH] Updated Comments:BIP 0047 (markdown) --- Comments:BIP-0047.md | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/Comments:BIP-0047.md b/Comments:BIP-0047.md index 188fb33..3251e54 100644 --- a/Comments:BIP-0047.md +++ b/Comments:BIP-0047.md @@ -1,3 +1,8 @@ Poorly designed. I recommend against implementing this version. --Luke Dashjr, 2016-12-23 -I support the goal. But this proposal is not well designed, and the way that it has been implemented in practice is by clients sending their scanning codes to third party servers; linking all of their payments-- a design flaw that was called out early in this (and related proposals lives). --Greg Maxwell, 2017-03-14 \ No newline at end of file +I support the goal. But this proposal is not well designed, and the way that it has been implemented in practice is by clients sending their scanning codes to third party servers; linking all of their payments-- a design flaw that was called out early in this (and related proposals lives). --Greg Maxwell, 2017-03-14 + +No comment as to design. However, I think that there is a typo in the Identity section. A sentence reads +"For example, the payment code created represented by (m / 47' / 0' / 0') is part of the account represented by (m / 44' / 0' / 0')." +I think that the account should not have a hardened final key pair. It should read "(m / 44' / 0' / 0)" instead. +-- Paul Imthurn, 2018-8-15 \ No newline at end of file