bitcoin/bips
1
0
Fork 0
mirror of https://github.com/bitcoin/bips.git synced 2025-05-26 12:10:14 +00:00
Code Issues Releases Wiki Activity

Updated Comments:BIP 0171 (markdown)

Stéphane Traumat 2018-08-21 18:07:46 +02:00
parent ec626a6b87
commit 34bfc8e5ce
1 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
Comments:BIP-0171.md

@ -9,7 +9,6 @@ CERISE ([website](http://www.cerise.tech/) & [github](https://github.com/strauma
* A collection of [client libraries](http://www.cerise.tech/#clients) to call any BIP-0171 compliant server with your favorite language. * A collection of [client libraries](http://www.cerise.tech/#clients) to call any BIP-0171 compliant server with your favorite language.
# Error management proposal ( by [straumat](https://github.com/straumat/) ) # Error management proposal ( by [straumat](https://github.com/straumat/) )
These are the different http status : These are the different http status :
* `200` : Everything worked as expected. * `200` : Everything worked as expected.
* `400` : The request was unacceptable, often due to missing a required parameter. * `400` : The request was unacceptable, often due to missing a required parameter.
@ -50,10 +49,7 @@ and then you have all the errors with, for each error found :
`message` : A human-readable message providing more details about the error. `message` : A human-readable message providing more details about the error.
*** # Change to make in the BIP ? ( by [straumat](https://github.com/straumat/) )
**Change to make in the BIP ?**
“a GET request to a common URI with parameters encoded in application/x-www-form-urlencoded format” “a GET request to a common URI with parameters encoded in application/x-www-form-urlencoded format”
May I ask you why parameters should be encoded this way ? From what I have seen in other projects, they also allow json for get method. May I ask you why parameters should be encoded this way ? From what I have seen in other projects, they also allow json for get method.
@ -63,7 +59,6 @@ I have the same comment for “minrate” and “maxrate” parameters in Curren
“digits - The type of digits to use for the quote currency's numbers. "arabic" should be used for common 0-9 digits.” Don’t you think we should provide the list of supported digits ? “digits - The type of digits to use for the quote currency's numbers. "arabic" should be used for common 0-9 digits.” Don’t you think we should provide the list of supported digits ?
**Things I don’t understand.** # Things I don’t understand ( by [straumat](https://github.com/straumat/) )
I don’t understand what means “XBTUSD-ver4” ? I don’t see what it means. I don’t understand what means “XBTUSD-ver4” ? I don’t see what it means.
“Currency-pair information \ symbol : Any positive or negative symbols must be included in this prefix/suffix” I don’t understand this rule. Can you explain it more please ? “Currency-pair information \ symbol : Any positive or negative symbols must be included in this prefix/suffix” I don’t understand this rule. Can you explain it more please ?
“grouping” : can you provide more informations about how it works ? I don’t understand if it’s only 3 fields or if you can have more ?