mirror of
https://github.com/bitcoin/bips.git
synced 2026-11-16 19:48:35 +00:00
Add Sign test vectors for a secnonce with k2' = 0 and for a secnonce generated for a different public key. No previous test vector detected an implementation that checks only k1', or one that omits the public key check added in 1.0.0-rc.2. Add test vectors for a single signer, a 4-byte extra_in, and plain and x-only tweaks in DeterministicSign. They detect implementations that reject a single signer, encode the length of extra_in as 32 whenever extra_in is present, or treat every tweak in DeterministicSign as x-only. Add a README to the vectors directory. It states that the test vectors only contain inputs whose length and number meet the specification of BIP327, and that a test vector should only be added if it detects a plausible implementation mistake that the other test vectors do not detect. Name that mistake in the comment of each added test vector. Co-authored-by: Ferdinando Ametrano <ferdinando@ametrano.net>
677 B
677 B
BIP327 test vectors
BIP327 specifies the length and number of the inputs of each algorithm, for example that each tweak is a 32-byte array and that there is one tweak mode for each tweak. The test vectors only contain inputs that meet these specifications. Since BIP327 does not specify how algorithms handle other inputs, such as a 31-byte tweak or a missing tweak mode, the test vectors do not test them.
A test vector should only be added if it detects a plausible implementation mistake that the other test vectors do not detect. The comment of the test vector names the mistake, for example "Detects implementations that set gacc to g instead of multiplying it by g".