From f71727f1c38ab42b7c28b50aa491b3243e04cbfd Mon Sep 17 00:00:00 2001 From: Steven Roose Date: Sat, 14 May 2016 14:21:46 +0200 Subject: [PATCH 1/3] BIP0009 code syntax fix --- bip-0009.mediawiki | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/bip-0009.mediawiki b/bip-0009.mediawiki index 509a8a94..e9b61eef 100644 --- a/bip-0009.mediawiki +++ b/bip-0009.mediawiki @@ -112,7 +112,7 @@ other one simultaneously transitions to STARTED, which would mean both would dem Note that a block's state never depends on its own nVersion; only on that of its ancestors. - case STARTED: { + case STARTED: if (GetMedianTimePast(block.parent) >= timeout) { return FAILED; } @@ -127,7 +127,6 @@ Note that a block's state never depends on its own nVersion; only on that of its if (count >= threshold) { return LOCKED_IN; } - } After a retarget period of LOCKED_IN, we automatically transition to ACTIVE. From 1a3613622b15cb85c301e3ab29697b8c19804421 Mon Sep 17 00:00:00 2001 From: Steven Roose Date: Sat, 14 May 2016 14:22:56 +0200 Subject: [PATCH 2/3] Error in BIP0009 code --- bip-0009.mediawiki | 1 + 1 file changed, 1 insertion(+) diff --git a/bip-0009.mediawiki b/bip-0009.mediawiki index e9b61eef..8941247a 100644 --- a/bip-0009.mediawiki +++ b/bip-0009.mediawiki @@ -127,6 +127,7 @@ Note that a block's state never depends on its own nVersion; only on that of its if (count >= threshold) { return LOCKED_IN; } + return STARTED; After a retarget period of LOCKED_IN, we automatically transition to ACTIVE. From 580db159079a7a8f0ee3d6646e7e6a668fce00a2 Mon Sep 17 00:00:00 2001 From: Steven Roose Date: Tue, 17 May 2016 02:06:18 +0200 Subject: [PATCH 3/3] Less visible error --- bip-0009.mediawiki | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bip-0009.mediawiki b/bip-0009.mediawiki index 8941247a..995ae85a 100644 --- a/bip-0009.mediawiki +++ b/bip-0009.mediawiki @@ -120,7 +120,7 @@ Note that a block's state never depends on its own nVersion; only on that of its walk = block; for (i = 0; i < 2016; i++) { walk = walk.parent; - if (walk.nVersion & 0xE0000000 == 0x2000000 && (walk.nVersion >> bit) & 1 == 1) { + if (walk.nVersion & 0xE0000000 == 0x20000000 && (walk.nVersion >> bit) & 1 == 1) { count++; } }