bitcoin/bips
1
0
Fork 0
mirror of https://github.com/bitcoin/bips.git synced 2026-05-04 16:41:51 +00:00
Code Issues Releases Wiki Activity

BIP-375: address review feedback

Browse Source 
correctly label witness_utxo vs non_witness_utxo key in supplementary inputs

Summary of test vector changes:
removed test: 
- psbt structure: empty PSBT_OUT_SCRIPT field when sending to non-sp output
modified test:
- ecdh coverage: only one ineligible P2SH multisig input when PSBT_OUT_SCRIPT set for sp output
- can finalize: one P2PKH input single-signer
- can finalize: two inputs using per-input ECDH shares - only eligible inputs contribute shares (P2SH excluded)
added test: 
- can finalize: two inputs using global ECDH share - only eligible inputs contribute shares (P2SH excluded)
This commit is contained in:
macgyver13
2026-03-30 15:39:35 -04:00
parent cf7a16a5f9
commit 7b4f1d6b4e
2 changed files with 67 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
bip-0375.mediawiki
View File

@@ -287,11 +287,8 @@ Use the provided [[bip-0375/test_runner.py|test runner]] to validate each test v
| PSBT Structure
| missing PSBT_OUT_SCRIPT field when sending to non-sp output
|-
| PSBT Structure
| empty PSBT_OUT_SCRIPT field when sending to non-sp output
|-
| ECDH Coverage
| only one ineligible P2MS input when PSBT_OUT_SCRIPT set for sp output
| only one ineligible P2SH multisig input when PSBT_OUT_SCRIPT set for sp output
|-
| ECDH Coverage
| missing PSBT_IN_SP_ECDH_SHARE field for input 0 when PSBT_OUT_SCRIPT set for sp output
@@ -346,7 +343,7 @@ Use the provided [[bip-0375/test_runner.py|test runner]] to validate each test v
! Description
|-
| Can Finalize
| one input single-signer
| one P2PKH input single-signer
|-
| Can Finalize
| two inputs single-signer using global ECDH share
@@ -373,7 +370,10 @@ Use the provided [[bip-0375/test_runner.py|test runner]] to validate each test v
| two sp outputs - output 0 uses label=3 / output 1 uses label=1
|-
| Can Finalize
| two mixed input types - only eligible inputs contribute ECDH shares (P2SH excluded)
| two inputs using per-input ECDH shares - only eligible inputs contribute shares (P2SH excluded)
|-
| Can Finalize
| two inputs using global ECDH share - only eligible inputs contribute shares (P2SH excluded)
|-
| Can Finalize
| two mixed input types - only eligible inputs contribute ECDH shares (NUMS internal key excluded)