From 78126a5f0c417c5ac51a5a1c3a3c9db6a7902c46 Mon Sep 17 00:00:00 2001 From: Antoine Poinsot Date: Fri, 13 Mar 2026 15:21:56 -0400 Subject: [PATCH] bip54: move comment as first element in txsize test vectors This is part of feedback received during the Bitcoin Inquisition PR review. --- bip-0054/test_vectors/txsize.json | 48 +++++++++++++++---------------- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/bip-0054/test_vectors/txsize.json b/bip-0054/test_vectors/txsize.json index 251bff4e..f886dd74 100644 --- a/bip-0054/test_vectors/txsize.json +++ b/bip-0054/test_vectors/txsize.json @@ -1,62 +1,62 @@ [ { + "comment": "A 63-byte legacy transaction.", "tx": "0200000001827da3d85a6547d6b03662d2cb86982d655a6f390547285a3bf9ec9f28e0c8831500000000ffffffff0100000000000000000300515200000000", - "valid": true, - "comment": "A 63-byte legacy transaction." + "valid": true }, { + "comment": "A 61-byte legacy transaction with a witness.", "tx": "02000000000101827da3d85a6547d6b03662d2cb86982d655a6f390547285a3bf9ec9f28e0c8831500000000ffffffff01000000000000000000010000000000", - "valid": true, - "comment": "A 61-byte legacy transaction with a witness." + "valid": true }, { + "comment": "A 64-byte legacy transaction (4 bytes in spk).", "tx": "0200000001827da3d85a6547d6b03662d2cb86982d655a6f390547285a3bf9ec9f28e0c8831500000000ffffffff010000000000000000040051525400000000", - "valid": false, - "comment": "A 64-byte legacy transaction (4 bytes in spk)." + "valid": false }, { + "comment": "A 64-byte legacy transaction (4 bytes in scriptsig).", "tx": "0200000001827da3d85a6547d6b03662d2cb86982d655a6f390547285a3bf9ec9f28e0c883150000000403424242ffffffff010040075af07507000000000000", - "valid": false, - "comment": "A 64-byte legacy transaction (4 bytes in scriptsig)." + "valid": false }, { + "comment": "A 65-byte legacy transaction.", "tx": "0200000001827da3d85a6547d6b03662d2cb86982d655a6f390547285a3bf9ec9f28e0c8831500000000ffffffff01000000000000000005005152545800000000", - "valid": true, - "comment": "A 65-byte legacy transaction." + "valid": true }, { + "comment": "A 64-byte Segwit transaction.", "tx": "02000000000101827da3d85a6547d6b03662d2cb86982d655a6f390547285a3bf9ec9f28e0c8831500000000ffffffff01000000000000000004005152540108213245576281941200000000", - "valid": false, - "comment": "A 64-byte Segwit transaction." + "valid": false }, { + "comment": "A 64-byte Segwit transaction (1 p2tr input, 1 p2a output).", "tx": "02000000000101827da3d85a6547d6b03662d2cb86982d655a6f390547285a3bf9ec9f28e0c8831500000000ffffffff0100000000000000000451024e7301415a78b5a14a2527feb02c08b8124e74c3b9bcc1bd3dba1fbfa87f1c930f28a46fea2bf375105dfd835e212c9127aad4976c46ef86be02edbb681e6f38f9a9e06f0100000000", - "valid": false, - "comment": "A 64-byte Segwit transaction (1 p2tr input, 1 p2a output)." + "valid": false }, { + "comment": "Historical 64-byte transaction 892f44a49de6f5b212cdbea514d09e692d9fed5d897f37bcef14bd0eedebf193", "tx": "0200000001deb98691723fa71260ffca6ea0a7bc0a63b0a8a366e1b585caad47fb269a2ce401000000030251b201000000010000000000000000016a00000000", - "valid": false, - "comment": "Historical 64-byte transaction 892f44a49de6f5b212cdbea514d09e692d9fed5d897f37bcef14bd0eedebf193" + "valid": false }, { + "comment": "Historical 64-byte transaction bbf71454857438c6dfd64c0d92a7c5360a8d8d57c9202f5806449e5b0d26b848", "tx": "01000000010d0afe3d74062ee60c0ec55579d691d8c8af5c04eb97b777157a21a8c5fb143d00000000035101b100000000010000000000000000016a01000000", - "valid": false, - "comment": "Historical 64-byte transaction bbf71454857438c6dfd64c0d92a7c5360a8d8d57c9202f5806449e5b0d26b848" + "valid": false }, { + "comment": "Historical 64-byte transaction 6713d61a83e3d095582211ea8d6db452ac7561e863decba7c4046fb9f6d88aa0", "tx": "02000000011658a33df410379bb512206659910c9fbd0e50bfb732f7be9936558ff036919401000000035101b201000000010000000000000000016a00000000", - "valid": false, - "comment": "Historical 64-byte transaction 6713d61a83e3d095582211ea8d6db452ac7561e863decba7c4046fb9f6d88aa0" + "valid": false }, { + "comment": "Historical 64-byte transaction 7f2efc6546011ad3227b2da678be0d30c7f4b08e2ce57b5edadd437f9e27a612", "tx": "02000000011a7a4cf262fb7e53e2e6e0b2ef8b763f6ee97d8681ca968d1938418d56e6c38700000000035101b201000000010000000000000000016a00000000", - "valid": false, - "comment": "Historical 64-byte transaction 7f2efc6546011ad3227b2da678be0d30c7f4b08e2ce57b5edadd437f9e27a612" + "valid": false }, { + "comment": "Historical 64-byte transaction 5302e01dc4b7e34314a34c7c3347107e612b9524be684d388cd4d2ca35ff1ec9", "tx": "01000000019222bbb054bb9f94571dfe769af5866835f2a97e883959fa757de4064bed8bca01000000035101b100000000010000000000000000016a01000000", - "valid": false, - "comment": "Historical 64-byte transaction 5302e01dc4b7e34314a34c7c3347107e612b9524be684d388cd4d2ca35ff1ec9" + "valid": false } ] \ No newline at end of file