From 45fbec92cd6a1d016d96d6ce7616f9b346056112 Mon Sep 17 00:00:00 2001 From: Danbo <140512416+dannbbb1@users.noreply.github.com> Date: Mon, 16 Dec 2024 15:23:08 -0500 Subject: [PATCH] BIPs 348 and 379: spelling fixups (#1715) * Update bip-0348.md * Update bip-0379.md --- bip-0348.md | 2 +- bip-0379.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/bip-0348.md b/bip-0348.md index 82bdcc85..d65a0d75 100644 --- a/bip-0348.md +++ b/bip-0348.md @@ -50,7 +50,7 @@ successful. ## Design Considerations 1. Message hashing: [BIP 340] is compatible with any size of message and does not require it to be a securely hashed input, so the message is not hashed prior to [BIP 340] verification. -2. Lack of verify semantics: Adding a single opcode for this purpose keeps the implementation and design simple. An earlier draft had a verify variant as a NOP upgrade, and if this funcationality is later brought to legacy scripts, that would be a good time to add a verify variant. +2. Lack of verify semantics: Adding a single opcode for this purpose keeps the implementation and design simple. An earlier draft had a verify variant as a NOP upgrade, and if this functionality is later brought to legacy scripts, that would be a good time to add a verify variant. 3. Add/multisig: No concession is made to `OP_CHECKMULTISIG` or `OP_CHECKSIGADD` semantics with `OP_CHECKSIGFROMSTACK`. In Tapscript, add semantics can be implemented with 1 additional vByte per key (`OP_TOALTSTACK OP_CHECKSIGFROMSTACK OP_FROMALTSTACK OP_ADD`). 4. Splitting R/S on the stack: Implementing split/separate signatures is left as an exercise for other bitcoin upgrades, such as [BIP 347] (`OP_CAT`). 5. APO-style ([BIP 118]) Taproot internal key: Rather than introducing an additional key type in this change, we suggest implementing `OP_INTERNALKEY` ([BIP 349]) or separately introducing that key type for all Tapscript signature checking operations in a separate change. diff --git a/bip-0379.md b/bip-0379.md index 10755d4e..c8e6b160 100644 --- a/bip-0379.md +++ b/bip-0379.md @@ -52,7 +52,7 @@ specifications apply to both. P2SH and bare scripts are excluded from this speci ### Translation Table -Miniscript consists of a set of script *fragments* which are designed to be safely and correctly composabe. +Miniscript consists of a set of script *fragments* which are designed to be safely and correctly composable. This table shows all Miniscript *fragments* and their associated semantics and Bitcoin Script. Fragments that do not change the semantics of their subexpressions are called *wrappers*. Normal