bitcoin/bips
1
0
Fork 0
mirror of https://github.com/bitcoin/bips.git synced 2025-05-19 12:08:05 +00:00
Code Issues Releases Wiki Activity

taproot_output_script: first returned byte should be OP_1 (0x51)

Browse Source 
If we look at

  def IsPayToTaproot(script):
      return len(script) == 35 and script[0] == OP_1 and script[1] == 33 and script[2] >= 0 and script[2] <= 1

First byte is is checked for OP_1. OP_1 is 0x51

But the example code in this BIP returns  

`bytes([0x01, 0x21, output_pubkey[0] & 1]) + output_pubkey[1:]`

First byte 0x01, but it should be 0x51
This commit is contained in:
Dmitry Petukhov 2019-05-10 03:09:54 +05:00 committed by GitHub
parent 27e61d61e6
commit 0c49346c87
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
bip-taproot.mediawiki
View File

@ -203,7 +203,7 @@ def taproot_output_script(internal_pubkey, script_tree):
t = tagged_hash("TapTweak", internal_pubkey.get_bytes() + h) t = tagged_hash("TapTweak", internal_pubkey.get_bytes() + h)
assert int.from_bytes(t, 'big') < SECP256K1_ORDER assert int.from_bytes(t, 'big') < SECP256K1_ORDER
output_pubkey = internal_pubkey.tweak_add(t).get_bytes() output_pubkey = internal_pubkey.tweak_add(t).get_bytes()
return bytes([0x01, 0x21, output_pubkey[0] & 1]) + output_pubkey[1:] return bytes([0x51, 0x21, output_pubkey[0] & 1]) + output_pubkey[1:]
</source> </source>
The function <code>taproot_output_script</code> returns a byte array with the scriptPubKey. It can be P2SH wrapped if desired (see BIP141). The function <code>taproot_output_script</code> returns a byte array with the scriptPubKey. It can be P2SH wrapped if desired (see BIP141).